SYCL: Fix GGML_SYCL_DEBUG macro #11995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ggml
ggerganov
approved these changes
Feb 21, 2025
It enables the backend specific logging system only when I previously tried to use GGML_LOG_DEBUG but the maintainers of the SYCL backend told me that it is way too verbose to separate the backend logs from the rest of the logging system for debugging purposes. |
Alcpz
approved these changes
Feb 21, 2025
|
To be fair to ggerganov's question we could rework it to have |
|
I think this should be merged now. |
orca-zhang
pushed a commit
to orca-zhang/llama.cpp
that referenced
this pull request
Feb 26, 2025
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
mostlyuseful
pushed a commit
to mostlyuseful/llama.cpp
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, this work was part of #11515. Currently this macro doesn't work on files other than ggml-sycl.cpp because of a variable
g_ggml_sycl_debugwhich gets initialized as a local variable only on ggml-sycl.cpp.This change enables the macro on other files.
I have also added debug logs to softmax OP function which I removed it then because of the mentioned issue.