Vulkan: add OP sigmoid #12056
Merged
Vulkan: add OP sigmoid #12056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Vulkan
jeffbolznv
approved these changes
Feb 25, 2025
|
LGTM. I verified the backend tests passed on RTX 4070. Can you point me to the exact model you used for perf testing? I'd like to try it out. |
Moonlight from Moonshot, a lite version of DeepSeek-V3. |
|
Thanks. I tried Moonlight-16B-A3B-Instruct-Q4_K_M.gguf and I see an improvement from 104->144 t/s with this change. |
orca-zhang
pushed a commit
to orca-zhang/llama.cpp
that referenced
this pull request
Feb 26, 2025
Co-authored-by: Judd <[email protected]>
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
Co-authored-by: Judd <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Mar 19, 2025
Co-authored-by: Judd <[email protected]>
mostlyuseful
pushed a commit
to mostlyuseful/llama.cpp
that referenced
this pull request
May 12, 2025
Co-authored-by: Judd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP_SIGMOIDis used by Deepseek-V3 and Moonlight. Implement this operator can make these models run faster on Vulkan backend.T/S Performance comparison on Moonlight Q8_0 with 2080Ti, generating ~200 tokens: