-
Notifications
You must be signed in to change notification settings - Fork 12.1k
ggml-cpu: Fix build with sve #12059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ggml-cpu: Fix build with sve #12059
Conversation
Signed-off-by: Molly Sophia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi @Vithulep
@MollySophia Can you also fix the "unused variable" warning in this PR? |
Sure! sry that I left that one |
Signed-off-by: Molly Sophia <[email protected]>
Can You mention the System Information you have build. On My system it was showing only warning. Initially My code was same what you added, but i have changed to earlier one. Because removing memcpy contributes to better cache usage, efficient use of memory bandwidth. |
Hi. Here's some of my system information:
|
Thank you! This is because of the different gcc compiler version. I am Using gcc 13.1.0 and got warning. |
* ggml-cpu: Fix build with sve Signed-off-by: Molly Sophia <[email protected]> * ggml-cpu: Remove unused variable in sve q3_k vec dot Signed-off-by: Molly Sophia <[email protected]> --------- Signed-off-by: Molly Sophia <[email protected]>
* ggml-cpu: Fix build with sve Signed-off-by: Molly Sophia <[email protected]> * ggml-cpu: Remove unused variable in sve q3_k vec dot Signed-off-by: Molly Sophia <[email protected]> --------- Signed-off-by: Molly Sophia <[email protected]>
* ggml-cpu: Fix build with sve Signed-off-by: Molly Sophia <[email protected]> * ggml-cpu: Remove unused variable in sve q3_k vec dot Signed-off-by: Molly Sophia <[email protected]> --------- Signed-off-by: Molly Sophia <[email protected]>
* ggml-cpu: Fix build with sve Signed-off-by: Molly Sophia <[email protected]> * ggml-cpu: Remove unused variable in sve q3_k vec dot Signed-off-by: Molly Sophia <[email protected]> --------- Signed-off-by: Molly Sophia <[email protected]>
Fix build issue when __ARM_FEATURE_SVE is enabled: