Skip to content

build: fix build error when build source code on Windows #12157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zhouwg
Copy link
Contributor

@zhouwg zhouwg commented Mar 3, 2025

I know nothing about Windows programming, but it seems there is a minor build error when build latest source code on Windows after verified twice:

Screenshot from 2025-03-03 13-19-00

pls help to close this PR accordingly if this is a misunderstanding, thanks.

@zhouwg
Copy link
Contributor Author

zhouwg commented Mar 10, 2025

I guess this is a compiler/toolchain issue again(gcc15 in cygwin is too strict and no such issue with llvm-mingw on x86-64 Windows) again after I successfully build llama.cpp for target WoA(Windows on ARM) in pure command line mode(without MS's huge VS2022 IDE) on host x86-64 Windows through llvm-mingw toolchain yesterday:#12215

so I 'd like to close this PR accordingly. thanks for your comments and valuable time in this PR.

btw, there is a minor tech issue(I think the root cause of this issue is MS's cmake seems different with cmake on Linux):

Screenshot from 2025-03-10 13-23-38

https://github.com/kantv-ai/ggml-qnn/blob/build_fix/cmake/arm64-windows-llvm.cmake#L5

I think it's not appropriate to submit another PR to fix this minor issue and your great team can handle it properly in the future.

@zhouwg zhouwg closed this Mar 10, 2025
zhouwg added a commit to zhouwg/ggml-hexagon that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants