Skip to content

opencl: Noncontiguous norm, rms_norm, disable fp16 for some ops #12217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

lhez
Copy link
Contributor

@lhez lhez commented Mar 6, 2025

This PR adds support for noncontiguous norm and rms_norm and also disables fp16 for ADD, MUL, SCALE, RELU, GELU, SILU, CLAMP. This should fix test-backend-ops failure/crash.

@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Mar 6, 2025
@lhez lhez marked this pull request as ready for review March 6, 2025 20:14
Copy link
Collaborator

@ericcurtin ericcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericcurtin ericcurtin merged commit d76a86d into ggml-org:master Mar 7, 2025
47 checks passed
mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
…ggml-org#12217)

* opencl: support noncontiguous `norm`

* opencl: support noncontiguous `rms_norm`

* opencl: disable fp16 for `ADD`, `MUL`, `SCALE`, `RELU`, `GELU`, `SILU`, `CLAMP`
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Mar 19, 2025
…ggml-org#12217)

* opencl: support noncontiguous `norm`

* opencl: support noncontiguous `rms_norm`

* opencl: disable fp16 for `ADD`, `MUL`, `SCALE`, `RELU`, `GELU`, `SILU`, `CLAMP`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants