Skip to content

SYCL: Delete redundant plus sign and space #12391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2025
Merged

SYCL: Delete redundant plus sign and space #12391

merged 1 commit into from
Mar 15, 2025

Conversation

aubreyli
Copy link
Contributor

Delete redundant plus sign and space in function ggml_sycl_mul_mat_id()

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Mar 14, 2025
@qnixsynapse qnixsynapse mentioned this pull request Mar 15, 2025
Closed
fairydreaming
fairydreaming approved these changes Mar 15, 2025
View reviewed changes
Copy link
Collaborator

@fairydreaming fairydreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, shouldn't affect calculation results as value of unary + operator is the value of its operand. To make sure I confirmed this with llama-embedding, got exactly the same result with and without this change.

NeoZhangJianyu
NeoZhangJianyu approved these changes Mar 15, 2025
View reviewed changes
Copy link
Collaborator

@NeoZhangJianyu NeoZhangJianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! :)

@fairydreaming fairydreaming merged commit 3d35d87 into ggml-org:master Mar 15, 2025
47 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Mar 19, 2025
@aubreyli @arthw
SYCL: Delete redundant plus sign and space (ggml-org#12391)
874af05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeoZhangJianyu NeoZhangJianyu NeoZhangJianyu approved these changes

@fairydreaming fairydreaming fairydreaming approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aubreyli @NeoZhangJianyu @fairydreaming