Skip to content

sycl: fixed compilation warnings #12424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

sycl: fixed compilation warnings #12424

merged 1 commit into from
Mar 18, 2025

Conversation

lslusarczyk
Copy link
Contributor

  1. Fixed deprecated intel::reqd_sub_group_size, see llvm release notes: Deprecated intel::reqd_sub_group_size, the official SYCL 2020 spelling should be used instead (with sycl:: namespace).
  2. Added static keyword to functions which symbols do not need to be exported
  3. Removed excessive, non-reachable break statements.

These are warnings issued by latest llvm compiler.

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Mar 17, 2025
@lslusarczyk lslusarczyk mentioned this pull request Mar 17, 2025
Merged
@lslusarczyk lslusarczyk marked this pull request as ready for review March 17, 2025 14:15
@Alcpz Alcpz changed the title fixed compilation warnings in ggml-sycl sycl: fixed compilation warnings Mar 17, 2025
NeoZhangJianyu
NeoZhangJianyu approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@NeoZhangJianyu NeoZhangJianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK to update the code to rm the warning for next release compiler.
We only use the stable compiler in official oneAPI package.

It's great if optimize OPs or implement unsupported OPs.

Thank you!

@NeoZhangJianyu NeoZhangJianyu merged commit a53f7f7 into ggml-org:master Mar 18, 2025
47 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Mar 19, 2025
@lslusarczyk @arthw
fixed compilation warnings in ggml-sycl (ggml-org#12424)
b1972f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alcpz Alcpz Alcpz approved these changes

@Rbiessy Rbiessy Rbiessy approved these changes

@NeoZhangJianyu NeoZhangJianyu NeoZhangJianyu approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lslusarczyk @Alcpz @Rbiessy @NeoZhangJianyu