Skip to content

llama : let context be const when accessing const data #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2023
Merged

llama : let context be const when accessing const data #1261

merged 1 commit into from
May 1, 2023

Conversation

grencez
Copy link
Contributor

@grencez grencez commented May 1, 2023

It helps clarify thread-safety and ownership in the API, particularly for llama_token_to_str().

@ggerganov ggerganov merged commit 90b19bd into ggml-org:master May 1, 2023
@grencez grencez deleted the const_to_str branch May 1, 2023 07:39
@Bearsaerker Bearsaerker mentioned this pull request Mar 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grencez @ggerganov