Fix includes in arg.cpp and gemma3-cli.cpp

[barracuda156]

Wonder how this was missed. The source uses filesystem, but does not include it.

[ngxson]

I think cinttype is not necessary in gemma3-cli, isn't it ?

[barracuda156]

I think cinttype is not necessary in gemma3-cli, isn't it ?

As long as __STDC_FORMAT_MACROS are defined, C header will still work, AFAIK. I changed it to C++ one for style reason, that can be dropped, only __STDC_FORMAT_MACROS are required there.

[ngxson]

I mean, the code of this example is the same as all other examples. If you're changing this in one example you should either:

1. Move this change to a common header, like common.h
2. Or, apply it to every other files.

[barracuda156]

I mean, the code of this example is the same as all other examples.

It is not. It is the only file here which uses PRI* macros, but does not include cinttypes.

llama.cpp/examples/llava/gemma3-cli.cpp

Line 173 in 7a84777

LOG("Image encoded in %" PRId64 " ms\n", ggml_time_ms() - t0);

In every other place cinttypes is already included. __STDC_FORMAT_MACROS are not defined, but my compiler is satisfied with just cinttypes, so I did not get errors on other files. But some compilers still need __STDC_FORMAT_MACROS even with cinttypes.

But you are right, identical change should be made in other places as well.

I think _STDC_FORMAT_MACROS should be removed

[barracuda156]

@ngxson Ok, I drop them, and change the header in gemma3-cli.cpp to the appropriate one.

[barracuda156]

@ngxson @ggerganov Done

[barracuda156]

Thanks for merging!