-
Notifications
You must be signed in to change notification settings - Fork 12.2k
[CANN]Support Opt CONV_TRANSPOSE_1D and ELU #12786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b6e6e28
[CANN] Support ELU and CONV_TRANSPOSE_1D
c466847
[CANN]Modification review comments
da17220
[CANN]Modification review comments
574621d
[CANN]name adjustment
7b69662
[CANN]remove lambda used in template
153b34d
[CANN]Use std::func instead of template
09cb721
[CANN]Modify the code according to the review comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,4 @@ | ||
#ifndef CANN_ACLNN_OPS | ||
#define CANN_ACLNN_OPS | ||
|
||
/** | ||
* @file acl_tensor | ||
* @brief This file contains related functions of ggml_tensor and acl_tensor. | ||
* Contains conversion from ggml_tensor to acl_tensor, broadcast and other | ||
* functions. | ||
* @author hipudding <[email protected]> | ||
* @author wangshuai09 <[email protected]> | ||
* @date July 15, 2024 | ||
* | ||
* Copyright (c) 2023-2024 The ggml authors | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
|
@@ -31,6 +20,9 @@ | |
* IN THE SOFTWARE. | ||
*/ | ||
|
||
#ifndef CANN_ACLNN_OPS | ||
#define CANN_ACLNN_OPS | ||
|
||
#include <aclnnop/aclnn_abs.h> | ||
#include <aclnnop/aclnn_neg.h> | ||
#include <aclnnop/aclnn_exp.h> | ||
|
@@ -483,8 +475,8 @@ void ggml_cann_rope(ggml_backend_cann_context& ctx, ggml_tensor* dst); | |
* operation is executed using the CANN backend for optimized performance. | ||
* | ||
* @param ctx The CANN context used for operations. | ||
* @param dst The destination tensor where the indices of the maximum values will be stored. | ||
* dst->op is `GGML_OP_ARGMAX`. | ||
* @param dst The destination tensor where the indices of the maximum values will | ||
* be stored. dst->op is `GGML_OP_ARGMAX`. | ||
*/ | ||
void ggml_cann_argmax(ggml_backend_cann_context& ctx, ggml_tensor* dst); | ||
|
||
|
@@ -600,40 +592,8 @@ void aclnn_sin(ggml_backend_cann_context& ctx, aclTensor* acl_src, | |
aclTensor* acl_dst); | ||
|
||
/** | ||
* @brief Launches an asynchronous task using the memory allocator. | ||
* | ||
* This macro submit an asynchronous task on the specified stream. | ||
* The task uses memory allocated by the allocator. It is guaranteed | ||
* that the memory will not be accessed by other tasks until this task | ||
* completes, due to the sequential execution order within the same stream. | ||
* | ||
* @param OP_NAME aclnn operator name. | ||
* @param args Additional arguments required by the task. | ||
* | ||
* @note | ||
* Memory from the allocator will be "freed" immediately and can be | ||
* reallocated to other pointers. However, it won't be accessed by any | ||
* other task before this asynchronous task ends, because all tasks in the | ||
* same stream are executed in queue order. | ||
*/ | ||
#define GGML_CANN_CALL_ACLNN_OP(OP_NAME, ...) \ | ||
do { \ | ||
uint64_t workspaceSize = 0; \ | ||
aclOpExecutor * executor; \ | ||
void * workspaceAddr = nullptr; \ | ||
\ | ||
ACL_CHECK(aclnn##OP_NAME##GetWorkspaceSize(__VA_ARGS__, &workspaceSize, &executor)); \ | ||
\ | ||
if (workspaceSize > 0) { \ | ||
ggml_cann_pool_alloc workspace_allocator(ctx.pool(), workspaceSize); \ | ||
workspaceAddr = workspace_allocator.get(); \ | ||
} \ | ||
ACL_CHECK(aclnn##OP_NAME(workspaceAddr, workspaceSize, executor, ctx.stream())); \ | ||
} while (0) | ||
|
||
|
||
/** | ||
* @brief Prepares broadcast-compatible ACL tensors for two input tensors and one output tensor. | ||
* @brief Prepares broadcast-compatible ACL tensors for two input tensors and one | ||
* output tensor. | ||
* | ||
* This function checks whether broadcasting is needed between `src0` and `src1`. | ||
* If broadcasting is required, it calculates the proper shapes and creates | ||
|
@@ -647,14 +607,57 @@ void aclnn_sin(ggml_backend_cann_context& ctx, aclTensor* acl_src, | |
* @param acl_src1 Output pointer to the created ACL tensor corresponding to src1. | ||
* @param acl_dst Output pointer to the created ACL tensor corresponding to dst. | ||
*/ | ||
void bcast_shape(ggml_tensor * src0, ggml_tensor * src1, ggml_tensor * dst, aclTensor ** acl_src0, | ||
aclTensor ** acl_src1, aclTensor ** acl_dst); | ||
void bcast_shape(ggml_tensor * src0, ggml_tensor * src1, ggml_tensor * dst, | ||
aclTensor ** acl_src0, aclTensor ** acl_src1, aclTensor ** acl_dst); | ||
|
||
/** | ||
* @brief Computes the 1D transposed convolution (deconvolution) of a ggml | ||
* tensor using the CANN backend. | ||
* | ||
* @details This function performs a 1D transposed convolution (also known as | ||
* deconvolution) operation on the input tensor. The computed result is stored | ||
* in the destination tensor `dst`. The operation is optimized using the CANN | ||
* backend for improved performance. | ||
* | ||
* @param ctx The CANN context used for operations. | ||
* @param dst The destination tensor where the transposed convolution result | ||
* will be stored. dst->op is `GGML_OP_CONV_TRANSPOSE_1D`. | ||
*/ | ||
void ggml_cann_conv_transpose_1d(ggml_backend_cann_context& ctx, ggml_tensor* dst); | ||
|
||
/** | ||
* @brief Applies a element-wise operation to two input tensors using the CANN backend. | ||
* @brief Applies the ELU (Exponential Linear Unit) activation to a ggml tensor | ||
* using the CANN backend. | ||
* | ||
* @details This function performs an element-wise ELU activation on the input | ||
* tensor. | ||
* The result is written to the destination tensor `dst` in-place. | ||
* The ELU function is defined as: | ||
* | ||
* \text{ELU}(x) = | ||
* \begin{cases} | ||
* x, & \text{if } x > 0 \\ | ||
* \alpha \left( \exp(x) - 1 \right), & \text{if } x \leq 0 | ||
* \end{cases} | ||
* | ||
* This templated function takes a binary operator and applies it to two source tensors | ||
* associated with the destination tensor. The function handles broadcasting as needed. | ||
* where α (alpha) is a hyperparameter, typically set to 1.0. | ||
* This operation is optimized using the CANN backend for high-performance | ||
* inference or training. | ||
* | ||
* @param ctx The CANN context used for operations. | ||
* @param dst The destination tensor where the ELU-activated result will be stored. | ||
* dst->op is expected to be `GGML_OP_ELU`. | ||
*/ | ||
void ggml_cann_elu(ggml_backend_cann_context& ctx, ggml_tensor* dst); | ||
|
||
/** | ||
* @brief Applies a element-wise operation to two input tensors using the CANN | ||
* backend. | ||
* | ||
* This templated function takes a binary operator and applies it to two source | ||
* tensors | ||
* associated with the destination tensor. The function handles broadcasting as | ||
* needed. | ||
* | ||
* @tparam binary_op A callable object (e.g., lambda or function pointer) representing | ||
* the binary operation to be performed. It must take three arguments: | ||
|
@@ -681,6 +684,38 @@ void ggml_cann_binary_op(ggml_backend_cann_context& ctx, ggml_tensor* dst) { | |
ACL_CHECK(aclDestroyTensor(acl_dst)); | ||
} | ||
|
||
/** | ||
* @brief Launches an asynchronous task using the memory allocator. | ||
* | ||
* This macro submit an asynchronous task on the specified stream. | ||
* The task uses memory allocated by the allocator. It is guaranteed | ||
* that the memory will not be accessed by other tasks until this task | ||
* completes, due to the sequential execution order within the same stream. | ||
* | ||
* @param OP_NAME aclnn operator name. | ||
* @param args Additional arguments required by the task. | ||
* | ||
* @note | ||
* Memory from the allocator will be "freed" immediately and can be | ||
* reallocated to other pointers. However, it won't be accessed by any | ||
* other task before this asynchronous task ends, because all tasks in the | ||
* same stream are executed in queue order. | ||
*/ | ||
#define GGML_CANN_CALL_ACLNN_OP(OP_NAME, ...) \ | ||
do { \ | ||
uint64_t workspaceSize = 0; \ | ||
aclOpExecutor * executor; \ | ||
void * workspaceAddr = nullptr; \ | ||
\ | ||
ACL_CHECK(aclnn##OP_NAME##GetWorkspaceSize(__VA_ARGS__, &workspaceSize, &executor)); \ | ||
\ | ||
if (workspaceSize > 0) { \ | ||
ggml_cann_pool_alloc workspace_allocator(ctx.pool(), workspaceSize); \ | ||
workspaceAddr = workspace_allocator.get(); \ | ||
} \ | ||
ACL_CHECK(aclnn##OP_NAME(workspaceAddr, workspaceSize, executor, ctx.stream())); \ | ||
} while (0) | ||
|
||
/** | ||
* @brief Applies a unary operation to an input tensor using the CANN backend. | ||
* | ||
|
@@ -690,7 +725,6 @@ void ggml_cann_binary_op(ggml_backend_cann_context& ctx, ggml_tensor* dst) { | |
* @tparam unary_op A callable with the signature: | ||
* void(ggml_backend_cann_context&, aclTensor*, aclTensor*) | ||
* where the first aclTensor is the source and the second is the destination. | ||
* | ||
* @param ctx The CANN backend context for managing resources and execution. | ||
* @param dst The destination tensor. Its src[0] is treated as the input tensor. | ||
*/ | ||
|
@@ -702,10 +736,30 @@ template <void unary_op(ggml_backend_cann_context&, aclTensor*, aclTensor*)> | |
aclTensor* acl_dst = ggml_cann_create_tensor(dst); | ||
|
||
unary_op(ctx, acl_src, acl_dst); | ||
|
||
ACL_CHECK(aclDestroyTensor(acl_src)); | ||
ACL_CHECK(aclDestroyTensor(acl_dst)); | ||
} | ||
|
||
/** | ||
* @brief Applies a unary operation to a ggml tensor using the CANN backend. | ||
* | ||
* @details This function performs a unary operation on the input tensor using | ||
* a user-provided lambda or callable object `unary_op`, which accepts the CANN | ||
* context and two ACL tensors (source and destination). Internally, this function | ||
* creates ACL representations of the ggml tensors and invokes the unary operation. | ||
* The result is stored in the destination tensor `dst`. This utility abstracts the | ||
* common boilerplate of tensor conversion and cleanup when implementing unary ops. | ||
* | ||
* @param unary_op A callable that performs the unary operation using CANN APIs. | ||
* @param ctx The CANN context used for operations. | ||
* @param dst The destination tensor where the result will be stored. | ||
* The source tensor is retrieved from `dst->src[0]`. | ||
*/ | ||
void ggml_cann_unary_op( | ||
std::function<void(ggml_backend_cann_context&, aclTensor*, aclTensor*)> unary_op, | ||
ggml_backend_cann_context& ctx, ggml_tensor* dst); | ||
|
||
/** | ||
* @brief Helper macro to invoke a unary ACL operation using ggml_cann_unary_op. | ||
* | ||
|
@@ -725,11 +779,12 @@ template <void unary_op(ggml_backend_cann_context&, aclTensor*, aclTensor*)> | |
*/ | ||
#define GGML_CANN_CALL_UNARY_OP(OP_NAME) \ | ||
do { \ | ||
auto lambda = [](auto ctx, auto acl_src, auto acl_dst) { \ | ||
auto lambda = [](ggml_backend_cann_context& ctx, \ | ||
aclTensor* acl_src, \ | ||
aclTensor* acl_dst) { \ | ||
GGML_CANN_CALL_ACLNN_OP(OP_NAME, acl_src, acl_dst); \ | ||
}; \ | ||
ggml_cann_unary_op<lambda>(ctx, dst); \ | ||
ggml_cann_unary_op(lambda, ctx, dst); \ | ||
} \ | ||
while (0) | ||
|
||
#endif // CANN_ACLNN_OPS |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.