ci: detach common from the library #12827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pminev
changed the title
ggerganov
approved these changes
Apr 9, 2025
ngxson
approved these changes
Apr 9, 2025
colout
pushed a commit
to colout/llama.cpp
that referenced
this pull request
Apr 21, 2025
* fix: detach common from the library * fix: building chat test template
timwu
pushed a commit
to timwu/llama.cpp
that referenced
this pull request
May 5, 2025
* fix: detach common from the library * fix: building chat test template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that now projects that will depend on llama will have common as include path. This sometimes there might be include clashes if you have same dependencies like
minjafor example.The other fix if for chat template test and it's
u8prefix of the strings where I had problem with compiling it.