SYCL: Support sycl_ext_oneapi_limited_graph #12873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current usage of the SYCL-Graph extension checks for the `sycl_ext_oneapi_graph` device aspect. However, it is also possible to support `sycl_ext_oneapi_limied_graph` devices that don't support update
github-actions
bot
added
ggml
EwanC
commented
Apr 11, 2025
NeoZhangJianyu
approved these changes
Apr 11, 2025
Rbiessy
reviewed
Apr 11, 2025
qnixsynapse
reviewed
Apr 11, 2025
Rbiessy
approved these changes
Apr 11, 2025
qnixsynapse
approved these changes
Apr 11, 2025
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Apr 14, 2025
SYCL-Graph contains two aspects for reporting extension support. Make the relationship between the two aspects clearer to readers, as it wasn't immediately obvious to reviewers of a [application PR](ggml-org/llama.cpp#12873) using these aspects.
dm-vodopyanov
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 15, 2025
SYCL-Graph contains two aspects for a device to report extension support. Make the relationship between the two aspects clearer to readers, as it wasn't immediately obvious to reviewers of an [application PR](ggml-org/llama.cpp#12873) using these aspects.
colout
pushed a commit
to colout/llama.cpp
that referenced
this pull request
Apr 21, 2025
The current usage of the SYCL-Graph extension checks for the `sycl_ext_oneapi_graph` device aspect. However, it is also possible to support `sycl_ext_oneapi_limied_graph` devices that don't support update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current usage of the SYCL-Graph extension checks for the
sycl_ext_oneapi_graphdevice aspect. However, it is also possible to supportsycl_ext_oneapi_limied_graphdevices that don't support update. This is primarily OpenCL and Level-Zero backends to DPC++, as CUDA and HIP backends always have full graph support.Tested Using
./bin/test-backend-ops -b SYCL0 -o RWKV_WKV7and using SYCL_UR_TRACE to verify changes by usage of UR entry-points for implementation SYCL-Graph.CUDA backend to DPC++ supports the full graph aspect, and so can do update. This is update behavior is consistent both before and after the change, with usage of entry-points for both graph update and graph creation:
Level-Zero backend to DPC++ by default doesn't support the full graph aspect. Before this change, the code was falling back to the non-graph path.
With this change, I observe the graph path being used on Level-Zero