examples : add llama_init_from_gpt_params() common function to reduce duplicate code #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
approved these changes
May 2, 2023
ggerganov
requested changes
May 2, 2023
examples/common.h
Outdated
| // Model utils | ||
| // | ||
|
|
||
| struct llama_context * load_model_from_file(gpt_params & params); |
There was a problem hiding this comment.
Suggested change
| struct llama_context * load_model_from_file(gpt_params & params); | |
| struct llama_context * llama_init_from_gpt_params(const gpt_params & params); |
There was a problem hiding this comment.
Function name changed, and branch rebased/pushed.
There was a problem hiding this comment.
The argument should be const reference
deadprogram
force-pushed
the
example-refactor-to-common
branch
from
e983ec4 to
d08f53c
Compare
deadprogram
changed the title
…y all examples to use it, in order to reduce duplicate code Signed-off-by: deadprogram <[email protected]>
deadprogram
force-pushed
the
example-refactor-to-common
branch
from
d08f53c to
a032ac5
Compare
DannyDaemonic
pushed a commit
to DannyDaemonic/llama.cpp
that referenced
this pull request
May 2, 2023
…#1290) Signed-off-by: deadprogram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the examples to reduce duplicate code, by adding a new
load_model_from_file()common function.Consider this both a reduction of lines of code in the examples, and also a step towards #508