Skip to content

ci : move release workflow to a separate file #13362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Conversation

slaren
Copy link
Member

@slaren slaren commented May 7, 2025

  • Moves the workflow to generate releases to release.yml. While this adds some code duplication, it makes the workflow easier to understand and maintain.
  • The releases now only include the tools, instead of all examples and tests
  • Adds actions to install CUDA toolkit and determine tag names to reduce code duplication

Test run: https://github.com/slaren/llama.cpp/actions/runs/14888774492
Test release: https://github.com/slaren/llama.cpp/releases/tag/b5308

@github-actions github-actions bot added the devops improvements to build systems and github actions label May 7, 2025
@slaren slaren requested a review from Copilot May 7, 2025 19:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extracts the release workflow into a separate file and refines the release process to include only the necessary tools. It adds a new Windows setup action for installing specific CUDA Toolkit versions and a tag name determination action to streamline release naming.

  • Introduces a Windows CUDA Toolkit setup action supporting versions 11.7 and 12.4.
  • Implements an action to compute the release tag name based on the branch and commit count.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.github/actions/windows-setup-cuda/action.yml Adds composite steps to install CUDA Toolkit for two versions on Windows using PowerShell.
.github/actions/get-tag-name/action.yml Adds a composite action to determine the release’s tag name based on the current branch.

@slaren slaren merged commit 70a6991 into master May 8, 2025
40 checks passed
@slaren slaren deleted the sl/releases-workflow branch May 8, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants