Skip to content

vulkan: move common FA code to flash_attn_base.comp #13556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2025
Merged

vulkan: move common FA code to flash_attn_base.comp #13556

merged 3 commits into from
May 17, 2025

Conversation

jeffbolznv
Copy link
Collaborator

No description provided.

@jeffbolznv jeffbolznv requested a review from 0cc4m May 15, 2025 05:36
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels May 15, 2025
0cc4m
0cc4m approved these changes May 17, 2025
View reviewed changes
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0cc4m 0cc4m merged commit 2f5a4e1 into ggml-org:master May 17, 2025
40 checks passed
infil00p pushed a commit to baseweight/llama.cpp that referenced this pull request May 22, 2025
@jeffbolznv @infil00p
vulkan: move common FA code to flash_attn_base.comp (ggml-org#13556)
00bfec1 
* vulkan: move common FA code to flash_attn_base.comp

* vulkan: move common FA index/stride setup code to flash_attn_base.comp

* build fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0cc4m 0cc4m 0cc4m approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffbolznv @0cc4m