Skip to content

scripts : add option to compare commits in Debug #13806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025

Conversation

ggerganov
Copy link
Member

@ggerganov ggerganov commented May 26, 2025

Some changes like #13706 (comment) have more pronounced performance effects when running in Debug build. This PR adds an option to do that:

CMAKE_OPTS="-DCMAKE_BUILD_TYPE=Debug" ./scripts/compare-commits.sh ...

@github-actions github-actions bot added the script Script related label May 26, 2025
@slaren
Copy link
Member

slaren commented May 26, 2025

I have been setting cmake_opts directly via an env variable when I need to run compare-commits.sh with different build settings. It could be capitalized and made the standard way to do this.

@ggerganov ggerganov merged commit a26c4cc into master May 26, 2025
2 checks passed
@ggerganov ggerganov deleted the gg/scripts-add-debug-option branch May 26, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
script Script related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants