ggml : add ggml_repeat_4d #13824
Merged
ggml : add ggml_repeat_4d #13824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
reviewed
May 27, 2025
| struct ggml_context * ctx, | ||
| struct ggml_tensor * a, | ||
| int64_t ne0, int64_t ne1, int64_t ne2, int64_t ne3) { | ||
| const bool can_repeat = ggml_is_empty(a) || ( |
There was a problem hiding this comment.
What is the purpose of repeating empty tensors?
There was a problem hiding this comment.
This is to match the behavior of ggml_can_repeat, I think it prevents division by 0 (ne%0) in the conditions below.
In practice, I think it can be useful for one particular use case: in llama.cpp, when we do a warmup, IIRC we have 0 output tokens, so the embedding tensor right before output head has ne[1] == 0
github-actions
bot
added
the
ggml
ggerganov
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a variant of
ggml_repeatwhich allow arbitrary target shape