-
Notifications
You must be signed in to change notification settings - Fork 12.2k
docs: add s390x build documentation #14264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds dedicated build documentation for the s390x (IBM Z & LinuxONE) architecture, including CPU build instructions, model conversion steps, and performance tuning tips.
- Introduces
docs/build-s390x.md
with s390x-specific build and conversion guidance - Covers BLAS-enabled builds, GGUF model endian conversions, and IBM accelerator notes
- Details architectural performance tuning and support channels
Comments suppressed due to low confidence (4)
docs/build-s390x.md:2
- The link to
build.md
may not resolve correctly; prefix it with a relative path (e.g.,./build.md
) or use the full repository path to ensure it works from withindocs/
.
> This build documentation is specific only to IBM Z & LinuxONE mainframes (s390x). You can find the build documentation for other architectures: [build.md](build.md).
docs/build-s390x.md:73
- The hyperlink
hf.co/collections/...
is missing thehttps://
prefix and will render as a relative link; update it tohttps://hf.co/collections/...
.
You can find popular models pre-converted and verified at [s390x Ready Models](hf.co/collections/taronaeo/s390x-ready-models-672765393af438d0ccb72a08).
docs/build-s390x.md:120
- [nitpick] The phrase “No direction at the moment” is vague; consider rephrasing to something like “No support currently available” for clarity.
*Only available in IBM z16 or later system. No direction at the moment.*
docs/build-s390x.md:124
- [nitpick] The wording here is unclear; consider changing to “Not supported at this time” or similar to make it explicit.
*No direction at the moment.*
slaren
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the s390x specific build documentation. I've decided to separate it from the default
build.md
because we're a big-endian architecture that need more documentation to get up and running.Feel free to let me know if there are other ways to approach this documentation.
Please review this pull request and consider merging into the main repository. Thank you!