Skip to content

CMake: properly find and link to threading library #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CMake: properly find and link to threading library #166

wants to merge 1 commit into from

Conversation

arrowd
Copy link

@arrowd arrowd commented Mar 15, 2023

No description provided.

@etra0
Copy link
Contributor

etra0 commented Mar 15, 2023

I think this is a duplicate of #114

@arrowd
Copy link
Author

arrowd commented Mar 15, 2023

That change looks incomplete, I had to link both executables with pthreads.

@ggerganov
Copy link
Member

@arrowd Could you double check - linking just to ggml should be enough I think

@arrowd
Copy link
Author

arrowd commented Mar 16, 2023

Ah, right, it is sufficient to add Threads::Threads to the library only. I guess, my PR is unnecessary then.

@arrowd arrowd closed this Mar 16, 2023
@arrowd arrowd deleted the patch-1 branch March 16, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arrowd @etra0 @ggerganov