Draft: Metal max buffer workaround #1825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiltyj
commented
Jun 12, 2023
| ctx->buffers[ctx->n_buffers].name = name; | ||
| ctx->buffers[ctx->n_buffers].data = data; | ||
| ctx->buffers[ctx->n_buffers].size = size; | ||
| size_t sys_max_buffer_size = 2ul * 1024ul * 1024ul * 1024ul; // ctx->device.maxBufferLength; |
There was a problem hiding this comment.
Note: this is an artificial 2GB limit that I had in place to test this out, given I don't actually bump into maxBufferLength on my M1 Max.
Should be switched back to ctx->device.maxBufferLength once issues are worked out.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was my initial attempt at working around MTLBuffer.maxBufferLength last week. This seems to work for 7B models, but not for larger models (e.g. guanaco 65B).
I'll keep poking at it after hours, but creating this so others can take a look if/as they find time.