Fix regression of model loading performance when using mlock. #2204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance of subsequent runs when using mlock suffered a large regression from 2347463.
It appears that changing the mmap flag from MAP_SHARED to MAP_PRIVATE causes the model to be loaded into memory fresh each time. This PR changes llama_mmap to take a new parameter called has_lora which if true calls mmap with
MAP_PRIVATE
andPROT_READ | PROT_WRITE
otherwise usesMAP_SHARED
andPROT_READ
.Caveats:
has_lora
.