Skip to content

ggml: move op parameters from tensors to ggml_tensor::op_params #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 23, 2023

Conversation

slaren
Copy link
Member

@slaren slaren commented Jul 22, 2023

No description provided.

@slaren
Copy link
Member Author

slaren commented Jul 23, 2023

While doing this, I also noticed that there are a bunch of result->src[1] = NULL; in ops that isn't really necessary, as src is already initialized to NULL. I think this made sense for clarity before, but after moving src0 and src1 into an array, they seem out of place.
Should I remove these?

Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes lets remove the explicit NULLs

Btw, for PRs you can now add ggml-ci string somewhere in the commit message and this will trigger extra integration tests in the Azure cloud. The CI only monitors branches in this repo though. It's useful for future PRs

@slaren slaren merged commit 95a6c59 into ggml-org:master Jul 23, 2023
@slaren slaren deleted the ggml-op-params branch July 23, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants