Docker - Fix publish docker image in GitHub Registry #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would |
gjmulder
added
enhancement
|
Let me know if I need to do something here - not familiar with Docker |
I think this should work, I changed it and the login at least went well. It would be necessary to test if we have the appropriate permissions during the push of the image. @ggerganov can you authorize this PR? Ty! |
j-f1
approved these changes
Mar 20, 2023
it's working! ty |
Deadsg
pushed a commit
to Deadsg/llama.cpp
that referenced
this pull request
Dec 19, 2023
Decrement CUDA version and bump Ubuntu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR that was resolved (#132), the action defined to publish the packages used the user and token of the author of the commit in master.
In this case, I have been yours, but I do not have permissions for such an action.
That is why I have modified the file, so that the owner's token is included as a secret with the name
GHCR_PAT.It is important to select the read:packages & write:packages permissions.
NOTE: Checks will fail until the secret is included.