Fix scalar version of Q5_K when QK_K = 64 #2362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing the 64-weight block size for k-quants, at some point I switched
Q5_K
to use "type-0" quantization. Apparently I forgot to adjust the scalar version of the code.Thanks to @katsu560 and @netrunnereve for noticing the problem.
Performance is not too bad actually. On a Ryzen-7950x (with
AVX/AVX2
disabled), less than a factor of 2 slower thanAVX2
: