Chat UI: add a subtle loading animation #2466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
server-loading-animation
branch
from
906d4a4 to
5aacb88
Compare
akx
force-pushed
the
server-loading-animation
branch
from
5aacb88 to
326de8f
Compare
i had to watch the video 5 times 😄 |
If you use chrome the gradient on the video box makes it invisible 👀
|
|
Looks good! But I think it might need some tweaks for dark mode: Screen.Recording.2023-08-16.at.15.51.31.mov |
|
@jhen0409 TBH that doesn't look that bad either to me :) Less subtle, sure... |
@akx I think I uploaded the wrong screenshot (I edited 
|
akx
force-pushed
the
server-loading-animation
branch
from
326de8f to
5783716
Compare
|
Rebased. @jhen0409 Added dark mode overrides for the colors 👍 |
jhen0409
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a subtle loading animation to the text input box to make it a bit clearer that something's happening:
llamaload.mp4