server : always regenerate asset hpp before compile #2643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhen0409
force-pushed
the
server-ignore-hpp-asset
branch
from
ce29dc7 to
580e02e
Compare
jhen0409
force-pushed
the
server-ignore-hpp-asset
branch
from
d8e03ed to
af4960a
Compare
cebtenzzre
reviewed
Aug 17, 2023
|
I found it can be hard to keep things simple on Windows, the xxd command will required an additional setup. I‘m expect the minimum requirement for Windows is just cmake (or w64devkit), so i'll give it up for now. Also, it’s worth to make the ./deps.sh support for old version of xxd, so I’ll take that to an another PR. Also thanks to @cebtenzzre for the tip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
./examples/server/deps.shinto Makefile & CMakelists.txt, so we can avoid add the generated hpp files into git.I think this change should be helpful, as I realize that most PRs for the server example are often required to fix conflicts.
Also add
--no-downloadto skip preact bundle download for reducing the loadings. We can update it by run ./deps.sh manually if needed.TODO: