Skip to content

makefile: fix tests build #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

alonfaraj
Copy link
Contributor

@alonfaraj alonfaraj commented Aug 28, 2023

Makefile:

  • add missing tests build: test-tokenizer-1, test-tokenizer-0-llama, test-tokenizer-0-falcon
  • fix linkage: test-llama-grammar, test-grammar-parser
  • fix old test name
  • update .gitignore

@ggerganov - we should probably cover the tests build using make in CI?

- fix test name
- add missing tests build
@alonfaraj alonfaraj changed the title makefile: fix and tests build makefile: fix tests build Aug 28, 2023
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, we should add it to the CI

@ggerganov ggerganov merged commit 75fafcb into ggml-org:master Aug 28, 2023
akawrykow pushed a commit to akawrykow/llama.cpp that referenced this pull request Aug 29, 2023
* makefile:
- fix test name
- add missing tests build

* editorconfig : fixes

---------

Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants