llama.cpp: Fix wrong vsnprintf call in MS compiler #2856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Aug 28, 2023
akawrykow
pushed a commit
to akawrykow/llama.cpp
that referenced
this pull request
Aug 29, 2023
Co-authored-by: grahameth <->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in the logging output implementation. When compiled with Visual Studio, _vsnprintf was used instead of vsnprintf. _vsnprintf returns -1 when the buffer is too small, but the code expects the needed size.
This PR fixed that. I now tested vsnprintf on Windows and it seems to work in all cornercases as expected.
In the original implementation, I copied the define from an older codebase. That codebase needed to support older VS versions, which don't have access to vsnprintf. llama.cpp requires at least VS2019, so that is not an issue here.