Skip to content

arm64 support for windows #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 13, 2023
Merged

arm64 support for windows #3007

merged 14 commits into from
Sep 13, 2023

Conversation

es0m
Copy link
Contributor

@es0m es0m commented Sep 4, 2023 •
edited
Loading

  • can't use native __fp16 type as it's not supported by MSVC
  • check for system_processor ARM64
  • portable initialization for uint32x2_t
  • 'vdupq_n_f16' and 'vld1q_f16' undefined, so can't use __ARM_FEATURE_FP16_VECTOR_ARITHMETIC
  • added support to use "-A x64" and "-A arm64" CMAKE_GENERATOR_PLATFORM flags to cross-compile from non-matching platforms.

cebtenzzre
cebtenzzre reviewed Sep 4, 2023
View reviewed changes
@es0m
Copy link
Contributor Author

es0m commented Sep 5, 2023

so can this be accepted? @cebtenzzre ?

es0m
es0m commented Sep 5, 2023
View reviewed changes
@es0m
Copy link
Contributor Author

es0m commented Sep 7, 2023

@ggerganov , any issues with this or ok to merge?

cebtenzzre
cebtenzzre reviewed Sep 7, 2023
View reviewed changes
cebtenzzre
cebtenzzre reviewed Sep 9, 2023
View reviewed changes
@cebtenzzre
Copy link
Collaborator

Could you merge master to resolve the conflicts?

@cebtenzzre cebtenzzre merged commit b52b29a into ggml-org:master Sep 13, 2023
pkrmf pushed a commit to morlockstudios-com/llama.cpp that referenced this pull request Sep 26, 2023
@es0m @cebtenzzre @pkrmf
arm64 support for windows (ggml-org#3007)
f050be7 
Co-authored-by: Cebtenzzre <[email protected]>
@cmdr2 cmdr2 mentioned this pull request Apr 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebtenzzre cebtenzzre cebtenzzre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@es0m @cebtenzzre @es0m-msft