fix convert.py not working with int filename_stem #3028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebtenzzre
approved these changes
Sep 5, 2023
|
I'm curious what model files you can reproduce this with. The pytorch files I've tried have a str for filename_stem. And this is not specific to python 3.8; I believe it will happen on any python version. |
Pickle's an insane format. I can definitely believe weird stuff like this can happen. There should probably be a check to make sure it's either string or int? Otherwise it can be some random object. |
|
unsure, bit i needed it for https://huggingface.co/PY007/TinyLlama-1.1B-step-50K-105b/ |
|
https://huggingface.co/Green-Sky/TinyLlama-1.1B-step-50K-105b-GGUF/discussions/1 |
Green-Sky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix implicit int to string conversion not working on python 3.8.10