Skip to content

ggml-alloc : correctly check mmap return value for errors #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2023
Merged

ggml-alloc : correctly check mmap return value for errors #3075

merged 1 commit into from
Sep 8, 2023

Conversation

slaren
Copy link
Member

@slaren slaren commented Sep 8, 2023

Currently, ggml-alloc assumes that mmap returns NULL on failure, which is not correct.

May fix #3069

jhen0409
jhen0409 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@jhen0409 jhen0409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it works, it correctly allocates 32GB of virtual memory on iPhone & iPad. 👍

@slaren slaren merged commit ebc9608 into master Sep 8, 2023
@slaren slaren deleted the alloc-mmap-fix branch September 8, 2023 02:04
@jhen0409 jhen0409 mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhen0409 jhen0409 jhen0409 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excessively high memory consumption on iOS
2 participants
@slaren @jhen0409