Removing unused n_buffers and buffers fields from ggml_metal_context
#5129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
approved these changes
Jan 25, 2024
cebtenzzre
approved these changes
Jan 26, 2024
ggerganov
approved these changes
Jan 26, 2024
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Feb 3, 2024
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that, from what I can make out, the
n_buffersandbuffersfields fromggml_metal_contextare always0andnil, so they can just be removed, along with theggml_metal_buffertype for thebuffersarray.The
ggml_metal_get_bufferis also trimmed down as it doesn't have two code paths anymore.There are no performance benefits with this change (or rather, negligible benefits) but it's always nice to have less code to worry about.