make: add error message for bad CUDA version #5444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebtenzzre
reviewed
Feb 10, 2024
I am a proponent of this change, calling it CUDA_DOCKER_ARCH never made sense to me. |
Co-authored-by: Jared Van Bortel <[email protected]>
Btw, on similar note, we should rename |
slaren
approved these changes
Feb 13, 2024
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Mar 13, 2024
* make: add error message for bad CUDA version * Update Makefile Co-authored-by: Jared Van Bortel <[email protected]> --------- Co-authored-by: Jared Van Bortel <[email protected]>
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
* make: add error message for bad CUDA version * Update Makefile Co-authored-by: Jared Van Bortel <[email protected]> --------- Co-authored-by: Jared Van Bortel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5294 in the sense that there is an error message to tell the user what the problem is. The root problem is that for old CUDA versions
-arch=nativeis not supported. However, compiling for multiple compute capabilities like with cmake also has drawbacks: the compilation time would increase and nvcc does not seem to natively support compiling for multiple specific CUDA architectures in parallel. So you would instead have to compile multiple .cubin files and then link them together. And since this is only an issue for old CUDA versions I think it's fine to just add an error message that tells users how to fix it.Currently the error message tells the user to set
CUDA_DOCKER ARCH. The people with the problem were indeed using Docker but in principle you could have this exact same problem with bare metal. Should we rename the argument to something likeCUDA_ARCH?