Skip to content

Early return for zero size calls to get_tensor. #5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Early return for zero size calls to get_tensor. #5482

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89b1915
Early return for zero size calls to get_tensor.
manyoso Feb 13, 2024
a83f687
Update ggml-kompute.cpp
manyoso Feb 13, 2024
4ca3d40
Update ggml-kompute.cpp
manyoso Feb 13, 2024
590e773
Add an early return to the get/set tensor when the size is null.
manyoso Feb 13, 2024
43bfc95
Early return after the assertions.
manyoso Feb 13, 2024
2d0586e
Since we do the early return in the generic backend now no reason to …
manyoso Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ggml-backend.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,10 @@ GGML_CALL void ggml_backend_tensor_set(struct ggml_tensor * tensor, const void *
GGML_ASSERT(buf != NULL && "tensor buffer not set");
GGML_ASSERT(offset + size <= ggml_nbytes(tensor) && "tensor write out of bounds");

if (!size) {
return;
}

tensor->buffer->iface.set_tensor(buf, tensor, data, offset, size);
}

Expand All @@ -229,6 +233,10 @@ GGML_CALL void ggml_backend_tensor_get(const struct ggml_tensor * tensor, void *
GGML_ASSERT(tensor->buffer != NULL && "tensor buffer not set");
GGML_ASSERT(offset + size <= ggml_nbytes(tensor) && "tensor read out of bounds");

if (!size) {
return;
}

tensor->buffer->iface.get_tensor(buf, tensor, data, offset, size);
}

Expand Down