Skip to content

ggml : always define ggml_fp16_t as uint16_t #5666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Conversation

ggerganov
Copy link
Member

@ggerganov ggerganov marked this pull request as ready for review February 22, 2024 17:19
@ggerganov ggerganov requested a review from slaren February 22, 2024 17:19
Copy link
Member

@slaren slaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any obvious issues, but I also don't know much about the ARM code.

@slaren
Copy link
Member

slaren commented Feb 22, 2024

A few more suspicious casts to float in ggml-quants.c:

5632:        const float d = y[i].d * (float)x[i].d;
5633:        const float dmin = -y[i].d * (float)x[i].dmin;
5782:        const float d = y[i].d * (float)x[i].d;
5783:        const float dmin = -y[i].d * (float)x[i].dmin;
6436:        const float d = y[i].d * (float)x[i].d;
6638:        const float d = y[i].d * (float)x[i].d;
7141:        sum_mins += y[i].d * (float)x[i].d[1] * summi;
7143:        const float d = y[i].d * (float)x[i].d[0];
7801:        const float d = y[i].d * (float)x[i].d;
7943:        const float d = y[i].d * (float)x[i].d;
8682:        const float d_all = (float)x[i].d;

@ggerganov ggerganov merged commit 7e4f339 into master Feb 22, 2024
@ggerganov ggerganov deleted the gg/simplify-fp16 branch February 22, 2024 21:21
jordankanter pushed a commit to jordankanter/llama.cpp that referenced this pull request Mar 13, 2024
* ggml : always define ggml_fp16_t as uint16_t

ggml-ci

* ggml : cont

ggml-ci

* ggml : cont

* ggml : cont

ggml-ci

* ggml : cont

ggml-ci

* cuda : no longer ggml headers last

ggml-ci

* ggml : fix q6_K FP16 -> FP32 conversion

ggml-ci

* ggml : more FP16 -> FP32 conversion fixes

ggml-ci
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
* ggml : always define ggml_fp16_t as uint16_t

ggml-ci

* ggml : cont

ggml-ci

* ggml : cont

* ggml : cont

ggml-ci

* ggml : cont

ggml-ci

* cuda : no longer ggml headers last

ggml-ci

* ggml : fix q6_K FP16 -> FP32 conversion

ggml-ci

* ggml : more FP16 -> FP32 conversion fixes

ggml-ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants