Skip to content

Add mac prebuilds to llama.cpp #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

Vaibhavs10
Copy link
Collaborator

@Vaibhavs10 Vaibhavs10 commented Mar 20, 2024

Hey hey!

Opening this PR to add the ability to ship prebuilt mac binaries for llama.cpp.

The way we create the binaries is quite simple we do so with the -DLLAMA_METAL_EMBED_LIBRARY=ON flag. We've tested this on an Intel Mac, M1, M2, & M3.

Shipping prebuilt metal binaries would significantly reduce the barrier of entry for the llama.cpp users.

Eventually, this would lead to an addition of llama.cpp in brew as well, which would allow the users to do brew install llama.cpp - even further reducing the friction.

Note: This work was done by @Narsil and I'm merely just upstreaming his work. Thanks Nicolas ❤️

@Vaibhavs10 Vaibhavs10 marked this pull request as draft March 20, 2024 16:55
@Vaibhavs10 Vaibhavs10 marked this pull request as ready for review March 21, 2024 08:31
@ggerganov ggerganov merged commit 5e43ba8 into ggml-org:master Mar 21, 2024
@Vaibhavs10 Vaibhavs10 deleted the add_mac_binaries branch March 21, 2024 09:15
@pgorzelany
Copy link

@Vaibhavs10 Any explanation on how to use the binary? Is it a command line app or something?

@loretoparisi
Copy link

Worth to add the doc how to use the new macOS binaries 🙏

@ggerganov
Copy link
Member

I suppose the main usage will be through brew - more details will follow

hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
* Initial commit - add mac prebuilds.

* forward contribution credits for building the workflow.

* minor : remove trailing whitespaces

---------

Co-authored-by: Nicolas Patry <[email protected]>
Co-authored-by: Georgi Gerganov <[email protected]>
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
* Initial commit - add mac prebuilds.

* forward contribution credits for building the workflow.

* minor : remove trailing whitespaces

---------

Co-authored-by: Nicolas Patry <[email protected]>
Co-authored-by: Georgi Gerganov <[email protected]>
tybalex pushed a commit to rubra-ai/tools.cpp that referenced this pull request Apr 17, 2024
* Initial commit - add mac prebuilds.

* forward contribution credits for building the workflow.

* minor : remove trailing whitespaces

---------

Co-authored-by: Nicolas Patry <[email protected]>
Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants