Handle server exception on wrong type in request #6452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
ggerganov
approved these changes
Apr 3, 2024
ngxson
reviewed
Apr 4, 2024
| } | ||
| catch (nlohmann::json_abi_v3_11_3::detail::type_error const&){ | ||
| std::string message = "Wrong type supplied for parameter '" + key + "'. Expected '" + typeid(default_value).name() + "', using default value."; | ||
| server_log("WARN", __func__, __LINE__, message.c_str(), body); |
There was a problem hiding this comment.
Maybe we can simply use LOG_WARNING here instead of calling directly server_log. But it's just a small detail, not important.
tybalex
pushed a commit
to rubra-ai/tools.cpp
that referenced
this pull request
Apr 17, 2024
Co-authored-by: Jonas Holzner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the http server shuts down when an argument is supplied as a wrong type in the request json. For example,
{"prompt": "Building a website can be done in 10 simple steps:","n_predict": 128, "stream": "false"}'(notice the "false" that is supplied as a string)will cause the following exception on the server:
The server shouldn't shut down from a malformed request. The proposed change catches this exception and logs a warning instead:
{"tid": ... ,"level":"WARN","function":"json_value","line":64,msg:"Wrong type supplied for parameter 'stream'. Expected 'b', using default value.","prompt":"Building a website can be done in 10 simple steps:","n_predict": 128,"stream":"false"}Not 100% sure if this is the right way to go about this, so feel free to let me know of any changes you would like to see!