Skip to content

[SYCL] Fixed minor bug when enabling FP16 for non intel targets #6464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 5, 2024
Merged

[SYCL] Fixed minor bug when enabling FP16 for non intel targets #6464

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4070423
moved INTEL_MKL guard from gemm_impl to gemm (wrapper)
OuadiElfarouki Mar 28, 2024
f746e70
Merge branch 'master' into sycl_fix_non_intel_fp16
OuadiElfarouki Mar 28, 2024
84ef62e
Update ggml-sycl.cpp
OuadiElfarouki Apr 3, 2024
c0c4b30
Merge branch 'master' into sycl_fix_non_intel_fp16
OuadiElfarouki Apr 3, 2024
a7c6758
Merge branch 'master' into sycl_fix_non_intel_fp16
OuadiElfarouki Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions ggml-sycl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,24 +1664,6 @@ namespace dpct
const void *alpha, const void *a, int lda, const void *b,
int ldb, const void *beta, void *c, int ldc)
{
#ifndef __INTEL_MKL__
GGML_UNUSED(q);
GGML_UNUSED(a_trans);
GGML_UNUSED(b_trans);
GGML_UNUSED(m);
GGML_UNUSED(n);
GGML_UNUSED(k);
GGML_UNUSED(alpha);
GGML_UNUSED(a);
GGML_UNUSED(lda);
GGML_UNUSED(b);
GGML_UNUSED(ldb);
GGML_UNUSED(beta);
GGML_UNUSED(c);
GGML_UNUSED(ldc);
throw std::runtime_error("The oneAPI Math Kernel Library (oneMKL) Interfaces "
"Project does not support this API.");
#else
Ts alpha_value = dpct::get_value(reinterpret_cast<const Ts *>(alpha), q);
Ts beta_value = dpct::get_value(reinterpret_cast<const Ts *>(beta), q);
auto data_a = get_memory<const Ta>(a);
Expand All @@ -1690,7 +1672,6 @@ namespace dpct
oneapi::mkl::blas::column_major::gemm(
q, a_trans, b_trans, m, n, k, alpha_value, data_a, lda,
data_b, ldb, beta_value, data_c, ldc);
#endif
}

template <typename VecT, class BinaryOperation, class = void>
Expand Down Expand Up @@ -2330,6 +2311,7 @@ namespace dpct
lda, b, ldb, beta, c, ldc);
break;
}
#ifdef __INTEL_MKL__
case detail::get_type_combination_id(
library_data_t::real_bfloat16, library_data_t::real_bfloat16,
library_data_t::real_float, library_data_t::real_float):
Expand Down Expand Up @@ -2391,6 +2373,7 @@ namespace dpct
q, a_trans, b_trans, m, n, k, &alpha_float, a, lda, b, ldb, &beta_float, c, ldc);
break;
}
#endif // __INTEL_MKL__
default:
throw std::runtime_error("the combination of data type is unsupported");
}
Expand Down