Skip to content

Comment explaining a decision #6531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2024
Merged

Comment explaining a decision #6531

merged 1 commit into from
Apr 8, 2024

Conversation

kunnis
Copy link
Contributor

@kunnis kunnis commented Apr 8, 2024 •
edited
Loading

Based on #6497

phymbert
phymbert approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@phymbert phymbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggerganov @tobi probably need to do the same on all TODO in :

https://github.com/ggerganov/llama.cpp/blob/b73e564b16086845a8b4fffd26e22685d3e0c3db/convert-hf-to-gguf.py#L162

@kunnis kunnis closed this Apr 8, 2024
@kunnis kunnis reopened this Apr 8, 2024
@phymbert phymbert merged commit cecd8d3 into ggml-org:master Apr 8, 2024
@kunnis kunnis deleted the convertComment branch April 8, 2024 15:47
tybalex pushed a commit to rubra-ai/tools.cpp that referenced this pull request Apr 17, 2024
@kunnis @tybalex
Comment explaining a decision (ggml-org#6531)
1797c28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

@phymbert phymbert phymbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunnis @ggerganov @phymbert