ci: fix binaries artifacts not uploaded to release #6612
Merged
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When action download-artifact was updated to v4, the default download path changed. This fix binaries not being uploaded to releases.
Yes, I tested it yesterday and made a release with binaries https://github.com/Hugi-R/llama.cpp/releases/tag/b2649 |
phymbert
approved these changes
Apr 11, 2024
|
Perfect, thanks! |
tybalex
pushed a commit
to rubra-ai/tools.cpp
that referenced
this pull request
Apr 17, 2024
When action download-artifact was updated to v4, the default download path changed. This fix binaries not being uploaded to releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GH action download-artifact was updated to v4 in 9f62c01, the default download path changed.
This fixes the file structure of the downloaded artifacts, that can then be uploaded again.