Skip to content

eval-callback: use ggml_op_desc to pretty print unary operator name #6631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

phymbert
Copy link
Collaborator

Context

Unary operator name was not printed.

Suggested by @slaren here: #6576 (comment)

Before:

ggml_debug:           ffn_moe_silu-0 = (f32)      UNARY(ffn_moe_gate-0{10752, 3, 1, 1}, }) = {10752, 3, 1, 1}
                                     [
                                      [
                                       [  0.0065,   4.0065,   8.0065, ...],
                                       [43008.0078, 43012.0078, 43016.0078, ...],
                                       [86016.0078, 86020.0078, 86024.0078, ...],
                                      ],
                                     ]
                                     sum = 387108.062500

After:

ggml_debug:           ffn_moe_silu-0 = (f32)       SILU(ffn_moe_gate-0{10752, 3, 1, 1}, }) = {10752, 3, 1, 1}
                                     [
                                      [
                                       [  0.0065,   4.0065,   8.0065, ...],
                                       [43008.0078, 43012.0078, 43016.0078, ...],
                                       [86016.0078, 86020.0078, 86024.0078, ...],
                                      ],
                                     ]
                                     sum = 387108.062500

@phymbert phymbert requested a review from slaren April 12, 2024 07:31
@phymbert phymbert merged commit 81da18e into master Apr 12, 2024
@phymbert phymbert deleted the hp/eval-callback/better-name branch April 12, 2024 08:26
tybalex pushed a commit to rubra-ai/tools.cpp that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants