Further tidy on Android instructions README.md #7077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some logic when following readme direction
Jeximo
commented
May 4, 2024
| @@ -951,7 +966,7 @@ $ export NDK=<your_ndk_directory> | |||
| $ cmake -DCMAKE_TOOLCHAIN_FILE=$NDK/build/cmake/android.toolchain.cmake -DANDROID_ABI=arm64-v8a -DANDROID_PLATFORM=android-23 -DCMAKE_C_FLAGS=-march=armv8.4a+dotprod .. | |||
| $ make | |||
| ``` | |||
| Install [termux](https://termux.dev/) on your device and run `termux-setup-storage` to get access to your SD card. | |||
| Install [termux](https://github.com/termux/termux-app#installation) on your device and run `termux-setup-storage` to get access to your SD card (if Android 11+ then run the command twice). | |||
There was a problem hiding this comment.
The reason to run the command twice is the first run pops the Android Permission Window, then user accepts. Now the permission is granted, which allows Termux to setup the symlinks to shared storage after second execution.
Jeximo
commented
May 4, 2024
| mv model.gguf ~/ | ||
| ``` | ||
|
|
||
| [Get the code](https://github.com/ggerganov/llama.cpp#get-the-code) & [follow the Linux build instructions](https://github.com/ggerganov/llama.cpp#build) to build `llama.cpp`. |
There was a problem hiding this comment.
Added link to Get the code so very new users can't miss it.
A new user arriving will see simple directions on llama.cpp homepage
Jeximo
commented
May 5, 2024
| Second, obtain the [Android NDK](https://developer.android.com/ndk) and then build with CMake: | ||
|
|
||
| You can execute the following commands on your computer to avoid downloading the NDK to your mobile. Of course, you can also do this in Termux. | ||
| Obtain the [Android NDK](https://developer.android.com/ndk) and then build with CMake: |
There was a problem hiding this comment.
Referring to termux doesn't make sense at this point - first step to building with ndk is obtain ndk.
Period after cmake, colon after termux
|
I think that's as clean as it gets! Let me know if there's anything you noticed that needs to be changed. |
method seems to be more correct, instead of alternative in this context
building llama.cpp with NDK on a pc doesn't require installing clang, cmake, git, or wget in termux.
|
@Jeximo this is renaming |
|
@slaren My apologies, I fixed the mistake. |
slaren
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed logic when following readme direction.
Some poor user got stuck trying to build
llama.cpp. This change makes the usergit clonebefore building.Listed Building with Termux, then Building with NDK as build directions should focus on what's necessary, whereas NDK instructions are optional. Removed redundency in NDK instruction.