-
Notifications
You must be signed in to change notification settings - Fork 12.2k
Added a single test function script and fix debug-test.sh to be more robust #7279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-test.sh to be more robust
Actually @josh-ramer when I ran
Am i reading it correctly? I would have thought that |
That comment is a little deceptive, what the code really does is find paths with Nice addition, makes sense to be able to execute as well. |
Maybe you can suggest a better comment? Either way, see if this script is working well for your flow and if I didn't break your gdb flow, then well should be good to go! |
I've got a review started, but there are no EC2 spot instance available right now (first time I've had that happen to my workflow) so I haven't run it yet to make sure it works, but as soon as they're available, I plan to run it for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will run as soon as I have the compute available.
@josh-ramer ready |
LGTM |
@josh-ramer see if you can press approve as there needs to be one other approval before it can merge in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like I don't have write access. I think that means I'd have to be added as a collaborator like you. |
@josh-ramer thanks. It's in now, hope it helps! |
Continuation of #7096 somewhat to address cases where a person may just want to run a single test.
Also discovered that the test binaries expects to be run in the git root context so need to fix debug-test.sh to take that into account.
@josh-ramer you may want to have a quick look a this to see if this would also be useful to you as well.
This is what the output visually looks like. With emphasis on the last three lines for clearer feedback
(Created this to try and more quickly pin down a CI issue)