Skip to content

fix typo in ggml.c #7603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024
Merged

fix typo in ggml.c #7603

merged 1 commit into from
May 29, 2024

Conversation

zhouwg
Copy link
Contributor

@zhouwg zhouwg commented May 29, 2024

No description provided.

@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label May 29, 2024
@Galunid Galunid merged commit 504f0c3 into ggml-org:master May 29, 2024
67 checks passed
Copy link
Contributor

📈 llama.cpp server for bench-server-baseline on Standard_NC4as_T4_v3 for phi-2-q4_0: 534 iterations 🚀

Expand details for performance related PR only
  • Concurrent users: 8, duration: 10m
  • HTTP request : avg=8767.17ms p(95)=21155.38ms fails=, finish reason: stop=480 truncated=54
  • Prompt processing (pp): avg=100.54tk/s p(95)=435.93tk/s
  • Token generation (tg): avg=49.45tk/s p(95)=46.22tk/s
  • ggml-org/models/phi-2/ggml-model-q4_0.gguf parallel=8 ctx-size=16384 ngl=33 batch-size=2048 ubatch-size=256 pp=1024 pp+tg=2048 branch=fix-typo-2 commit=d53f405727e27239e1ae1bc078c3170e27af46db

prompt_tokens_seconds

More
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 534 iterations"
    y-axis "llamacpp:prompt_tokens_seconds"
    x-axis "llamacpp:prompt_tokens_seconds" 1716949243 --> 1716949873
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 756.48, 756.48, 756.48, 756.48, 756.48, 595.14, 595.14, 595.14, 595.14, 595.14, 613.42, 613.42, 613.42, 613.42, 613.42, 691.18, 691.18, 691.18, 691.18, 691.18, 714.09, 714.09, 714.09, 714.09, 714.09, 716.26, 716.26, 716.26, 716.26, 716.26, 744.66, 744.66, 744.66, 744.66, 744.66, 761.58, 761.58, 761.58, 761.58, 761.58, 762.4, 762.4, 762.4, 762.4, 762.4, 771.23, 771.23, 771.23, 771.23, 771.23, 766.54, 766.54, 766.54, 766.54, 766.54, 726.57, 726.57, 726.57, 726.57, 726.57, 753.21, 753.21, 753.21, 753.21, 753.21, 771.15, 771.15, 771.15, 771.15, 771.15, 772.6, 772.6, 772.6, 772.6, 772.6, 775.15, 775.15, 775.15, 775.15, 775.15, 778.1, 778.1, 778.1, 778.1, 778.1, 776.81, 776.81, 776.81, 776.81, 776.81, 780.87, 780.87, 780.87, 780.87, 780.87, 781.56, 781.56, 781.56, 781.56, 781.56, 781.12, 781.12, 781.12, 781.12, 781.12, 786.8, 786.8, 786.8, 786.8, 786.8, 785.83, 785.83, 785.83, 785.83, 785.83, 788.08, 788.08, 788.08, 788.08, 788.08, 786.46, 786.46, 786.46, 786.46, 786.46, 787.79, 787.79, 787.79, 787.79, 787.79, 806.38, 806.38, 806.38, 806.38, 806.38, 803.17, 803.17, 803.17, 803.17, 803.17, 804.38, 804.38, 804.38, 804.38, 804.38, 804.97, 804.97, 804.97, 804.97, 804.97, 807.25, 807.25, 807.25, 807.25, 807.25, 811.34, 811.34, 811.34, 811.34, 811.34, 809.97, 809.97, 809.97, 809.97, 809.97, 811.41, 811.41, 811.41, 811.41, 811.41, 817.67, 817.67, 817.67, 817.67, 817.67, 825.63, 825.63, 825.63, 825.63, 825.63, 828.91, 828.91, 828.91, 828.91, 828.91, 824.23, 824.23, 824.23, 824.23, 824.23, 815.24, 815.24, 815.24, 815.24, 815.24, 815.22, 815.22, 815.22, 815.22, 815.22, 816.89, 816.89, 816.89, 816.89, 816.89, 818.68, 818.68, 818.68, 818.68, 818.68, 819.29, 819.29, 819.29, 819.29, 819.29, 829.62, 829.62, 829.62, 829.62, 829.62, 807.89, 807.89, 807.89, 807.89, 807.89, 779.03, 779.03, 779.03, 779.03, 779.03, 779.25, 779.25, 779.25, 779.25, 779.25, 778.22, 778.22, 778.22, 778.22, 778.22, 781.66, 781.66, 781.66, 781.66, 781.66, 781.46, 781.46, 781.46, 781.46, 781.46, 784.37, 784.37, 784.37, 784.37, 784.37, 787.36, 787.36, 787.36, 787.36, 787.36, 791.16, 791.16, 791.16, 791.16, 791.16, 792.84, 792.84, 792.84, 792.84, 792.84, 794.94, 794.94, 794.94, 794.94, 794.94, 799.72, 799.72, 799.72, 799.72, 799.72, 801.29, 801.29, 801.29, 801.29, 801.29, 801.29, 801.29, 801.29, 801.29, 801.29, 802.59, 802.59, 802.59, 802.59, 802.59, 804.97, 804.97, 804.97, 804.97, 804.97, 804.97]
                    
Loading
predicted_tokens_seconds
More
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 534 iterations"
    y-axis "llamacpp:predicted_tokens_seconds"
    x-axis "llamacpp:predicted_tokens_seconds" 1716949243 --> 1716949873
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 34.33, 34.33, 34.33, 34.33, 34.33, 32.6, 32.6, 32.6, 32.6, 32.6, 34.38, 34.38, 34.38, 34.38, 34.38, 34.88, 34.88, 34.88, 34.88, 34.88, 35.06, 35.06, 35.06, 35.06, 35.06, 36.31, 36.31, 36.31, 36.31, 36.31, 36.26, 36.26, 36.26, 36.26, 36.26, 36.49, 36.49, 36.49, 36.49, 36.49, 36.01, 36.01, 36.01, 36.01, 36.01, 35.56, 35.56, 35.56, 35.56, 35.56, 35.14, 35.14, 35.14, 35.14, 35.14, 34.42, 34.42, 34.42, 34.42, 34.42, 34.32, 34.32, 34.32, 34.32, 34.32, 32.17, 32.17, 32.17, 32.17, 32.17, 31.92, 31.92, 31.92, 31.92, 31.92, 29.6, 29.6, 29.6, 29.6, 29.6, 29.5, 29.5, 29.5, 29.5, 29.5, 29.82, 29.82, 29.82, 29.82, 29.82, 29.75, 29.75, 29.75, 29.75, 29.75, 29.45, 29.45, 29.45, 29.45, 29.45, 29.46, 29.46, 29.46, 29.46, 29.46, 29.64, 29.64, 29.64, 29.64, 29.64, 29.83, 29.83, 29.83, 29.83, 29.83, 29.88, 29.88, 29.88, 29.88, 29.88, 29.71, 29.71, 29.71, 29.71, 29.71, 29.8, 29.8, 29.8, 29.8, 29.8, 29.95, 29.95, 29.95, 29.95, 29.95, 29.89, 29.89, 29.89, 29.89, 29.89, 30.0, 30.0, 30.0, 30.0, 30.0, 30.26, 30.26, 30.26, 30.26, 30.26, 30.4, 30.4, 30.4, 30.4, 30.4, 30.47, 30.47, 30.47, 30.47, 30.47, 30.48, 30.48, 30.48, 30.48, 30.48, 30.51, 30.51, 30.51, 30.51, 30.51, 30.57, 30.57, 30.57, 30.57, 30.57, 30.44, 30.44, 30.44, 30.44, 30.44, 30.23, 30.23, 30.23, 30.23, 30.23, 29.98, 29.98, 29.98, 29.98, 29.98, 29.87, 29.87, 29.87, 29.87, 29.87, 30.06, 30.06, 30.06, 30.06, 30.06, 30.22, 30.22, 30.22, 30.22, 30.22, 30.33, 30.33, 30.33, 30.33, 30.33, 30.4, 30.4, 30.4, 30.4, 30.4, 30.42, 30.42, 30.42, 30.42, 30.42, 30.19, 30.19, 30.19, 30.19, 30.19, 29.52, 29.52, 29.52, 29.52, 29.52, 29.42, 29.42, 29.42, 29.42, 29.42, 29.06, 29.06, 29.06, 29.06, 29.06, 29.04, 29.04, 29.04, 29.04, 29.04, 29.05, 29.05, 29.05, 29.05, 29.05, 29.1, 29.1, 29.1, 29.1, 29.1, 29.18, 29.18, 29.18, 29.18, 29.18, 29.29, 29.29, 29.29, 29.29, 29.29, 29.31, 29.31, 29.31, 29.31, 29.31, 29.33, 29.33, 29.33, 29.33, 29.33, 29.28, 29.28, 29.28, 29.28, 29.28, 29.3, 29.3, 29.3, 29.3, 29.3, 29.45, 29.45, 29.45, 29.45, 29.45, 29.47, 29.47, 29.47, 29.47, 29.47, 29.61, 29.61, 29.61, 29.61, 29.61, 29.69]
                    
Loading

Details

kv_cache_usage_ratio

More
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 534 iterations"
    y-axis "llamacpp:kv_cache_usage_ratio"
    x-axis "llamacpp:kv_cache_usage_ratio" 1716949243 --> 1716949873
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.37, 0.37, 0.37, 0.37, 0.37, 0.21, 0.21, 0.21, 0.21, 0.21, 0.15, 0.15, 0.15, 0.15, 0.15, 0.19, 0.19, 0.19, 0.19, 0.19, 0.15, 0.15, 0.15, 0.15, 0.15, 0.13, 0.13, 0.13, 0.13, 0.13, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.21, 0.21, 0.21, 0.21, 0.21, 0.18, 0.18, 0.18, 0.18, 0.18, 0.29, 0.29, 0.29, 0.29, 0.29, 0.19, 0.19, 0.19, 0.19, 0.19, 0.4, 0.4, 0.4, 0.4, 0.4, 0.46, 0.46, 0.46, 0.46, 0.46, 0.44, 0.44, 0.44, 0.44, 0.44, 0.18, 0.18, 0.18, 0.18, 0.18, 0.2, 0.2, 0.2, 0.2, 0.2, 0.17, 0.17, 0.17, 0.17, 0.17, 0.34, 0.34, 0.34, 0.34, 0.34, 0.22, 0.22, 0.22, 0.22, 0.22, 0.18, 0.18, 0.18, 0.18, 0.18, 0.15, 0.15, 0.15, 0.15, 0.15, 0.19, 0.19, 0.19, 0.19, 0.19, 0.34, 0.34, 0.34, 0.34, 0.34, 0.16, 0.16, 0.16, 0.16, 0.16, 0.11, 0.11, 0.11, 0.11, 0.11, 0.33, 0.33, 0.33, 0.33, 0.33, 0.17, 0.17, 0.17, 0.17, 0.17, 0.12, 0.12, 0.12, 0.12, 0.12, 0.16, 0.16, 0.16, 0.16, 0.16, 0.16, 0.16, 0.16, 0.16, 0.16, 0.14, 0.14, 0.14, 0.14, 0.14, 0.24, 0.24, 0.24, 0.24, 0.24, 0.12, 0.12, 0.12, 0.12, 0.12, 0.17, 0.17, 0.17, 0.17, 0.17, 0.31, 0.31, 0.31, 0.31, 0.31, 0.35, 0.35, 0.35, 0.35, 0.35, 0.33, 0.33, 0.33, 0.33, 0.33, 0.11, 0.11, 0.11, 0.11, 0.11, 0.12, 0.12, 0.12, 0.12, 0.12, 0.16, 0.16, 0.16, 0.16, 0.16, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.39, 0.39, 0.39, 0.39, 0.39, 0.63, 0.63, 0.63, 0.63, 0.63, 0.44, 0.44, 0.44, 0.44, 0.44, 0.38, 0.38, 0.38, 0.38, 0.38, 0.15, 0.15, 0.15, 0.15, 0.15, 0.23, 0.23, 0.23, 0.23, 0.23, 0.26, 0.26, 0.26, 0.26, 0.26, 0.15, 0.15, 0.15, 0.15, 0.15, 0.1, 0.1, 0.1, 0.1, 0.1, 0.16, 0.16, 0.16, 0.16, 0.16, 0.19, 0.19, 0.19, 0.19, 0.19, 0.19, 0.19, 0.19, 0.19, 0.19, 0.18, 0.18, 0.18, 0.18, 0.18, 0.13, 0.13, 0.13, 0.13, 0.13, 0.15, 0.15, 0.15, 0.15, 0.15, 0.14, 0.14, 0.14, 0.14, 0.14, 0.15, 0.15, 0.15, 0.15, 0.15, 0.23]
                    
Loading
requests_processing
More
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 534 iterations"
    y-axis "llamacpp:requests_processing"
    x-axis "llamacpp:requests_processing" 1716949243 --> 1716949873
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 1.0, 1.0, 1.0, 1.0, 1.0, 8.0, 8.0, 8.0, 8.0, 8.0, 2.0, 2.0, 2.0, 2.0, 2.0, 5.0, 5.0, 5.0, 5.0, 5.0, 3.0, 3.0, 3.0, 3.0, 3.0, 0.0, 0.0, 0.0, 0.0, 0.0, 7.0, 7.0, 7.0, 7.0, 7.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 5.0, 5.0, 5.0, 5.0, 5.0, 7.0, 7.0, 7.0, 7.0, 7.0, 8.0, 8.0, 8.0, 8.0, 8.0, 6.0, 6.0, 6.0, 6.0, 6.0, 7.0, 7.0, 7.0, 7.0, 7.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 5.0, 5.0, 5.0, 5.0, 5.0, 8.0, 8.0, 8.0, 8.0, 8.0, 3.0, 3.0, 3.0, 3.0, 3.0, 5.0, 5.0, 5.0, 5.0, 5.0, 7.0, 7.0, 7.0, 7.0, 7.0, 3.0, 3.0, 3.0, 3.0, 3.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 4.0, 4.0, 4.0, 4.0, 4.0, 1.0, 1.0, 1.0, 1.0, 1.0, 8.0, 8.0, 8.0, 8.0, 8.0, 5.0, 5.0, 5.0, 5.0, 5.0, 8.0, 8.0, 8.0, 8.0, 8.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 2.0, 2.0, 2.0, 2.0, 2.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 6.0, 6.0, 6.0, 6.0, 6.0, 8.0, 8.0, 8.0, 8.0, 8.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 7.0, 7.0, 7.0, 7.0, 7.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 2.0, 2.0, 2.0, 2.0, 2.0, 4.0, 4.0, 4.0, 4.0, 4.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 7.0, 7.0, 7.0, 7.0, 7.0, 6.0, 6.0, 6.0, 6.0, 6.0, 8.0, 8.0, 8.0, 8.0, 8.0, 2.0, 2.0, 2.0, 2.0, 2.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 2.0]
                    
Loading

@zhouwg zhouwg deleted the fix-typo-2 branch June 6, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants