Skip to content

Fix conan badge display [no ci] #7645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024

Conversation

MartinDelille
Copy link
Contributor

Sorry for the second PR but I thought the badge didn't looked nice so I repositioned it to be next to the other ones.

@mofosyne
Copy link
Collaborator

Add [no ci] as it's a documentation only commit

@mofosyne mofosyne added merge ready indicates that this may be ready to merge soon and is just holding out in case of objections documentation Improvements or additions to documentation Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix labels May 30, 2024
@MartinDelille MartinDelille changed the title Fix conan badge display Fix conan badge display [no ci] May 30, 2024
@mofosyne
Copy link
Collaborator

mofosyne commented May 30, 2024

Ah, @MartinDelille what I mean is the commit title itself needs to say [no ci] use --amend then force push

https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs

@mofosyne mofosyne merged commit 5dcdf94 into ggml-org:master May 30, 2024
1 check passed
@mofosyne
Copy link
Collaborator

@MartinDelille thanks. All good now, merging

@MartinDelille MartinDelille deleted the update-conan-badge branch May 30, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation merge ready indicates that this may be ready to merge soon and is just holding out in case of objections Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants