convert-hf : set the model name based on cli arg, if present #7693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasha0552
force-pushed
the
convert-model-name
branch
2 times, most recently
from
dae4a38 to
3c41647
Compare
sasha0552
force-pushed
the
convert-model-name
branch
from
3c41647 to
ed6f58c
Compare
|
Just a heads up that this will conflict with the PR I am currently working on I will however add the corresponding corrections to account for your requirement. I think mine is almost ready but if it takes too long then we can add yours in if it passes peer review since it looks to be a smaller scope change. edit: Investigating the history it was first added in https://github.com/ggerganov/llama.cpp/blob/f4ab2a41476600a98067a9474ea8f9e6db41bcfa/convert-hf-to-gguf.py but strangely never used. |
mofosyne
added
the
Review Complexity : Low
mofosyne
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
convert-hf-to-gguf.pysimply ignored the--model-nameargument. Because of this, in my case the model name was equal to the commit hash (I convert models directly from the huggingface cache).