-
Notifications
You must be signed in to change notification settings - Fork 12.1k
[SYCL] Revert "use the correct SYCL context for host USM allocations" #7858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry about that, how can I reproduce this issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
We've encountered this on Nvidia GPUs for both |
@AidanBeltonS could you rebase to fix CI? Thanks |
I can't reproduce this on Intel GPU. could you have a deep dive why only issues exist on NVIDIA GPU? Maybe an issue to Intel SYCL team is more appropriate. cc some SYCL mates @Nuullll |
4e4ff76
to
a9cae48
Compare
Currently working on making a reproducer. It requires a model which uses pinned memory, it should not be a backend/hardware specific problem |
@airMeng the problem also effects intel devices. I have reproduced the error on a Data Max 1100. To reproduce: Backtrace:
|
Thanks, I can reproduce the error with these steps on an A750 also. Looking now... |
Manually reverting: #7858 Signed-off-by: Joe Todd <[email protected]>
Manually reverting: ggml-org#7858 Signed-off-by: Joe Todd <[email protected]>
Reverts #7777. This PR broke
llama-bench
andmain
as when pinned memory is allocated during the models creating the backend is not initialized. This means theg_sycl_gpu_mgr
is not constructed with the relevant devices. Causing a segfault as no devices exist within the manager.I think we should try to reintroduce #7777 in a more suitable way that addresses this issue.