Skip to content

added support for Authorization Bearer tokens when downloading model #8307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 6, 2024

Conversation

dwoolworth
Copy link
Contributor

@dwoolworth dwoolworth commented Jul 4, 2024

@dwoolworth dwoolworth requested a review from ngxson July 6, 2024 03:16
@shibe2
Copy link
Contributor

shibe2 commented Jul 6, 2024

Perhaps, you should mention in the title that the token is to be used for downloading models. Another place where HTTP authorization tokens may be involved is restricting access in server example.

@ngxson ngxson changed the title added support for Authorization Bearer tokens added support for Authorization Bearer tokens when downloading model Jul 6, 2024
Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge when CI passed

@ngxson ngxson merged commit 86e7299 into ggml-org:master Jul 6, 2024
53 checks passed
@dwoolworth
Copy link
Contributor Author

@ngxson and @shibe2 thank you for merging and for the help!

Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jul 8, 2024
…gml-org#8307)

* added support for Authorization Bearer tokens

* removed auth_token, removed set_ function, other small fixes

* Update common/common.cpp

---------

Co-authored-by: Xuan Son Nguyen <[email protected]>
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jul 8, 2024
…gml-org#8307)

* added support for Authorization Bearer tokens

* removed auth_token, removed set_ function, other small fixes

* Update common/common.cpp

---------

Co-authored-by: Xuan Son Nguyen <[email protected]>
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jul 11, 2024
…gml-org#8307)

* added support for Authorization Bearer tokens

* removed auth_token, removed set_ function, other small fixes

* Update common/common.cpp

---------

Co-authored-by: Xuan Son Nguyen <[email protected]>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
…gml-org#8307)

* added support for Authorization Bearer tokens

* removed auth_token, removed set_ function, other small fixes

* Update common/common.cpp

---------

Co-authored-by: Xuan Son Nguyen <[email protected]>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
…gml-org#8307)

* added support for Authorization Bearer tokens

* removed auth_token, removed set_ function, other small fixes

* Update common/common.cpp

---------

Co-authored-by: Xuan Son Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants