Skip to content

cmake : allow external ggml #8370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

iboB
Copy link
Contributor

@iboB iboB commented Jul 8, 2024

This is a minor change which allows the use of llama.cpp as a subdirectory with ggml provided externally (at one's own risk of course). As in:

add_subdirectory(ggml)
add_subdirectory(llama.cpp)

Check whether ggml is a target and if it is, assume it's added from a parent project

@github-actions github-actions bot added the build Compilation issues label Jul 8, 2024
@iboB iboB force-pushed the external-ggml branch from 695e5a5 to 496db9e Compare July 9, 2024 08:05
@iboB iboB force-pushed the external-ggml branch from 496db9e to dc4ee89 Compare July 9, 2024 08:09
@ggerganov ggerganov merged commit 9925ca4 into ggml-org:master Jul 9, 2024
47 of 52 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
@iboB iboB mentioned this pull request Jul 31, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Compilation issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants