ggml : Add GGML_USE_SVE macro to disable SVE by default #8426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
|
If I am not mistaken, this has already been addressed in #5780 by making it fall back to the NEON implementation if the vector size is not 256-bit. |
|
Thank you for comment, I missed that correction. It looks good. I close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue introduced in #8109.
In the previous update, GGML_NATIVE was enabled by default, which in turn enabled SVE by default. However, SVE currently only supports 256-bit operations in vec_dot, leading to errors when running on SVE 128-bit CPUs.
This fix ensures that SVE is not enabled unless GGML_SVE=ON is explicitly set at compile time.